-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add report thumbnails portlet #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkzia
force-pushed
the
add_report_thumbnail_portlet3
branch
from
June 20, 2019 18:53
b526407
to
a309f28
Compare
jpwhite4
previously approved these changes
Jun 21, 2019
Need to fix merge conflicts |
mkzia
force-pushed
the
add_report_thumbnail_portlet3
branch
from
July 12, 2019 14:00
0df896d
to
1d2155c
Compare
mkzia
force-pushed
the
add_report_thumbnail_portlet3
branch
from
July 12, 2019 14:05
1d2155c
to
3e85479
Compare
mkzia
force-pushed
the
add_report_thumbnail_portlet3
branch
from
July 12, 2019 18:51
f7d1c94
to
526c5bb
Compare
mkzia
force-pushed
the
add_report_thumbnail_portlet3
branch
from
July 12, 2019 18:57
526c5bb
to
7b15ac3
Compare
jpwhite4
approved these changes
Jul 12, 2019
jpwhite4
added a commit
to jpwhite4/xdmod
that referenced
this pull request
Dec 5, 2019
The pull request ubccr#967 added extra code to the report manager that manipulated the start and end times of charts in a report. This broke the report generator. These changes appear to not be necessary at all and must have been added by mistake.
jpwhite4
added a commit
that referenced
this pull request
Dec 6, 2019
Revert XDReportManager changes from #967
jpwhite4
added a commit
to jpwhite4/xdmod
that referenced
this pull request
Jan 15, 2020
The pull request ubccr#967 added extra code to the report manager that manipulated the start and end times of charts in a report. This broke the report generator. These changes appear to not be necessary at all and must have been added by mistake.
jtpalmer
pushed a commit
to jtpalmer/xdmod
that referenced
this pull request
Sep 25, 2020
The pull request ubccr#967 added extra code to the report manager that manipulated the start and end times of charts in a report. This broke the report generator. These changes appear to not be necessary at all and must have been added by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a portlet for displaying thumbnails of charts from a report in the summary tab. The following files were added/updated.
buildReportFromTemplate
function inclasses/ReportTemplates/GenericReportTemplate.php
to optionally accept report id suffix.classes/Rest/Controllers/SummaryControllerProvider.php
to add a new REST endpoint to return report based on user role.classes/XDReportManager.php
to accept user-specified start and end date for chart thumbnailsconfiguration/assets.json
to includeReportThumbnailsPortlet
configuration/etl/etl.d/xdmod-migration-8_1_2-8_5_0.json
to read templates and associated charts into staging tables and then copy the missing templates and charts to the production tablesconfiguration/etl/etl_action_defs.d/xdb/report-template-charts-staging.json
to define the template-charts staging table actionconfiguration/etl/etl_action_defs.d/xdb/report-template-charts.json
to add left join between the staging and production tableconfiguration/etl/etl_action_defs.d/xdb/report-templates-staging.json
to define the report templates staging table actionconfiguration/etl/etl_action_defs.d/xdb/report-templates.json
to add left join between the staging and production tableconfiguration/etl/etl_data.d/acls/report-template-acls-staging.json
to include CD and CS report templatesconfiguration/etl/etl_data.d/xdb/report-templates.json
to include new CD and CS reports.configuration/etl/etl_data.d/xdb/report-template-charts.json
to include details of the new CD and CS reports.configuration/etl/etl_tables.d/xdb/report-template-charts-staging.json
to define the template-charts staging tableconfiguration/etl/etl_tables.d/xdb/report-templates-staging.json
to define the template staging tablehtml/controllers/report_builder/send_report.php
to accept user-specified start and end date for PDF reportshtml/gui/css/ReportThumbnailsPortlet.css
to modifyReportThumbnailsPortlet
lookhtml/gui/js/modules/summary/ReportThumbnailsPortlet.js
-- contains the portlet definitionhtml/highchart_template.html
to changeNO DATA
title for empty thumbnails toNo data available for the criteria specified
tests/artifacts/xdmod/report_builder/output/cd_enum_templates.json
to include new report templatestests/artifacts/xdmod/report_builder/output/cs_enum_templates.json
to include new report templatestests/artifacts/xdmod/ui/output/reportGenerator.json
to include a new template for the center director. Also set center staffreport_templates_available
to true to pass the integration tests. Setting to true should be safe to do because the center director test path checks the rest of the functionality.tests/integration/lib/Rest/ReportThumbnailsTest.php
which has some basic integration tests.tests/ui/test/specs/xdmod/reportGenerator.js
to properly access report templates since there are now more than one templates. Also add CD template.tests/ui/test/specs/xdmod/reportGenerator.page.js
to properly access report templates since there are now more than one templatesTo enable, add the following to /etc/xdmod/roles.d/summary.json
Motivation and Context
Users need an easy way to get center snapshot. A portlet showing relevant chart thumbnails provides this snapshot.
Tests performed
Manually tested the code and added some simple integration tests.
Types of changes
Checklist: