From 2d42925ae80c0fb007aa39f4e210122611897255 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Mon, 30 May 2022 05:59:52 -0700 Subject: [PATCH] Define cc-compiler-darwin in Xcode toolchain Previously, if the xcode_locator failed and cc_autoconf_toolchain used the non-Xcode C++ toolchain as a fallback, its reference to `@local_config_cc//:cc-compiler-darwin`, where darwin is the legacy cpu value for x86_64 macOS, would be invalid. Fixes #14459 Closes #14796. PiperOrigin-RevId: 451860477 Change-Id: Iec115f600ebb7ac0786b2169276d25e3ff5d54bf --- tools/osx/crosstool/BUILD.tpl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/osx/crosstool/BUILD.tpl b/tools/osx/crosstool/BUILD.tpl index 216feb5ac3b52b..be90e1b1e8d339 100644 --- a/tools/osx/crosstool/BUILD.tpl +++ b/tools/osx/crosstool/BUILD.tpl @@ -80,6 +80,14 @@ cc_toolchain_suite( for arch in OSX_TOOLS_ARCHS ] +# When xcode_locator fails and causes cc_autoconf_toolchains to fall back +# to the non-Xcode C++ toolchain, it uses the legacy cpu value to refer to +# the toolchain, which is "darwin" for x86_64 macOS. +alias( + name = "cc-compiler-darwin", + actual = ":cc-compiler-darwin_x86_64", +) + [ cc_toolchain_config( name = arch,