Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be nice if an app could pass the causing error to Shutdowner #672

Open
dcormier opened this issue Apr 8, 2019 · 2 comments
Open

It would be nice if an app could pass the causing error to Shutdowner #672

dcormier opened this issue Apr 8, 2019 · 2 comments
Labels
enhancement

Comments

@dcormier
Copy link

dcormier commented Apr 8, 2019 •
edited
Loading

It would be nice if an error could optionally be passed to Shutdowner, and this could be retrieved from the App as the reason it stopped running. Users could then use that error to decide whether to exit the process with a non-zero status code, for example.
@hsblhsn
Copy link

hsblhsn commented Sep 10, 2022

Agree.

A simple ShutdownOption should do that. For example sd.Shutdown(fx.WithShutdownCause(err)).

What do you think?

@sywhang
Copy link
Contributor

sywhang commented Oct 12, 2022

This is a reasonable feature request. I'll start tracking it in our backlog :) Thanks for the suggestion.

@abramlab abramlab mentioned this issue Dec 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcormier @sywhang @hsblhsn