Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow zero slice using func #293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow zero slice using func #293

wants to merge 1 commit into from

Conversation

fatelei
Copy link

@fatelei fatelei commented Nov 16, 2024

fix #268

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ccoVeille
Copy link

No unit test? 😱🤔

@fatelei
Copy link
Author

fatelei commented Nov 16, 2024

No unit test? 😱🤔

i haven't find where to add ut

@ccoVeille
Copy link

Let's wait for a maintainer.

But good thing you took this issue

@ccoVeille
Copy link

As it's about slice, I would say here maybe

https://github.com/uber-go/nilaway/blob/main/testdata%2Fsrc%2Fgo.uber.org%2Fslices%2Fslices.go

@fatelei
Copy link
Author

fatelei commented Nov 16, 2024

As it's about slice, I would say here maybe

https://github.com/uber-go/nilaway/blob/main/testdata%2Fsrc%2Fgo.uber.org%2Fslices%2Fslices.go

ok, i will check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine tracking of slicing index
3 participants
@fatelei @CLAassistant @ccoVeille