-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Mute/None log level #729
Comments
Some related issues: #680 & #713 I think this is a slightly different request -- it's asking for a level that will never be logged, which allows for easily disabling logging via level. If we do this:
This makes sense at a high level to me, we should get another opinion too. |
A None level (with a large negative value) sounds reasonable to me. |
A |
If this is still something that is still desired then I'd like to take it up. |
Since adding a new level would be a breaking change, we'd like to avoid doing so in 1.0. We should defer this to a 2.0, whenever that happens. (#388) |
YARPC observability middleware allow users to specify a log level for (inbound, outbound) x (success, failure, application error) traffic edges as of yarpc/yarpc-go#1763. Users would like to be able to mute certain edges, such that they can see their own debug messages without seeing YARPC’s.
Currently, the best advice we can provide is to raise the development log level to "info" to suppress the YARPC debug logs, then raise application log messages to "info" during development, requiring the application debug log level to be configurable. This is acceptable but unpalatable.
To this end, would it be wise to introduce a new Mute or None debug level with numeric value -2? If so, I can initiate a change.
The text was updated successfully, but these errors were encountered: