Change default CoroutineContext from empty to default for the RibCoroutineWorker<>Worker conversion #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranAguilera
force-pushed
the
change_as_worker_dispatcher_to_default
branch
from
2e40bd1
to
94fffa8
Compare
psteiger
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently
com.uber.rib.core.RibCoroutineWorkertocom.uber.rib.core.Worker(.asWorker()) is using EmptyCoroutineContext for binding when the coroutineContext is not specified in.asWorker()callRelated issue(s):
This results in changing the
RibDispatchers.Defaultdispatcher on the originalRibCoroutineWorkerwhich results on binding the converted worker onRibDispatchers.Unconfined