From 31449649903e9a8dcb2dc0d5ebf1c264058c7109 Mon Sep 17 00:00:00 2001
From: Tatiana Romanova <tr@uber.com>
Date: Wed, 21 Aug 2019 09:33:54 +0200
Subject: [PATCH] Feedback: restructure testcases

---
 astro/cli/astro/cmd/flags_test.go | 41 +++++++++++++++++++------------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git a/astro/cli/astro/cmd/flags_test.go b/astro/cli/astro/cmd/flags_test.go
index 564c63b..4b377a2 100644
--- a/astro/cli/astro/cmd/flags_test.go
+++ b/astro/cli/astro/cmd/flags_test.go
@@ -81,28 +81,37 @@ func TestPlanErrorOnMissingValues(t *testing.T) {
 }
 
 func TestPlanAllowedValues(t *testing.T) {
-	tt := []string{
-		"mgmt",
-		"dev",
-		"staging",
-		"prod",
+	testcases := []struct {
+		env             string
+		expectedModules []string
+	}{
+		{
+			"mgmt",
+			[]string{"foo_mgmt-mgmt"},
+		},
+		{
+			"dev",
+			[]string{"misc-dev", "test_env-dev"},
+		},
+		{
+			"staging",
+			[]string{"misc-staging", "test_env-staging"},
+		},
+		{
+			"prod",
+			[]string{"misc-prod"},
+		},
 	}
-	expectedModules := map[string][]string{
-		"dev":     []string{"misc-dev", "test_env-dev"},
-		"mgmt":    []string{"foo_mgmt-mgmt"},
-		"staging": []string{"misc-staging", "test_env-staging"},
-		"prod":    []string{"misc-prod"},
-	}
-	for _, env := range tt {
-		t.Run(env, func(t *testing.T) {
+	for _, tt := range testcases {
+		t.Run(tt.env, func(t *testing.T) {
 			result := tests.RunTest(t, []string{
 				"--config=merge_values.yaml",
 				"plan",
 				"--environment",
-				env,
+				tt.env,
 			}, "fixtures/flags", tests.VERSION_LATEST)
-			// Check that all expected modules were planned for environment env
-			for _, module := range expectedModules[env] {
+			// Check that all expected modules were planned for environment
+			for _, module := range tt.expectedModules {
 				assert.Contains(t, result.Stdout.String(), module)
 			}