Constrain coslon in _geoAzDistanceRads
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
approved these changes
Mar 27, 2019
| @@ -221,36 +221,36 @@ void _geoAzDistanceRads(const GeoCoord* p1, double az, double distance, | |||
| if (fabs(p2->lat - M_PI_2) < EPSILON) // north pole | |||
| { | |||
| p2->lat = M_PI_2; | |||
| p2->lon = 0.0L; | |||
| p2->lon = 0.0; | |||
There was a problem hiding this comment.
What if anything is the affect of removing the L suffix? Do we lose precision? I'm guessing no, just wanted to understand if this is expected to be a no-op.
There was a problem hiding this comment.
p2->lon is a double, so this should have the same result.
The comparisons using long doubles are different, I assume in those cases the double variables are promoted to long doubles for the purpose of comparison. I believe that could possibly have issues in edge cases.
jogly
approved these changes
Mar 27, 2019
dfellis
approved these changes
Mar 27, 2019
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
Constrain `coslon` in `_geoAzDistanceRads`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#212
This needs additional tests to cover all the branches in this function. Lcov doesn't report it, but the branches around lines 250~253 are uncovered. Lcov only reports lines, so we don't know about untested code like this. If we can't have the coverage tool we use report branch coverage, we should consider setting the formatter to put the branch condition always on a new line.
It looks like the vertex issue is likely a copy+paste error resulting in
coslonbeing tested butsinlonbeing constrained. After fixing the index87dc6d364ffffffand it's neighbors look right.Unrelated to this, I noticed that we are using long double constants in this file, which I don't think is necessary since the library was changed to use doubles. I changed the constants in this function but not the other places in the library.