-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add h3ToCenterChild and getPentagonsAtRes #267
Add h3ToCenterChild and getPentagonsAtRes #267
Conversation
What are your thoughts on naming? The |
2b4061b
to
6b9d69c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contribution! Looking really good, just a few comments.
We also don't use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Looks good, I added some comments in addition to Nick's.
Thank you for all the feedback! I believe I've addressed it all. Please let me know if I've missed something. I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks for the follow-through on this PR!
…(the PR instead of issue)
Add h3ToCenterChild and getPentagonsAtRes
…(the PR instead of issue)
Follows up on #263. I have a use-case where I need to find the center child of a cell at a specific resolution.
I'm simply changing the four resolution bits, but it should be worth adding as a helper function to the core library (so we can keep treating the index as an opaque datatype).
Also adds
getPentagonsAtRes
which provides the user with the set of pentagon cells at any given resolution,Resolves #255 and #263.