Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add h3ToCenterChild and getPentagonsAtRes #267

Merged
merged 21 commits into from
Aug 7, 2019
Merged

Add h3ToCenterChild and getPentagonsAtRes #267

merged 21 commits into from
Aug 7, 2019

Commits on Aug 1, 2019

  1. Add H3GetCenterChild

    @zachasme
    zachasme committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    88309e8 View commit details
    Browse the repository at this point in the history

  2. Add getPentagonsAtRes

    @zachasme
    zachasme committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    2ca6a11 View commit details
    Browse the repository at this point in the history

  3. Add docs for getPentagonsAtRes and h3ToCenterChild

    @zachasme
    zachasme committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    6b9d69c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Fix nits on center child tests

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    a7da076 View commit details
    Browse the repository at this point in the history

  2. Fix nits for pentagonsAtRes tests

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    65351ca View commit details
    Browse the repository at this point in the history

  3. Add test for resolutions beyond max to h3ToChildren tests

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    db5558e View commit details
    Browse the repository at this point in the history

  4. Remove duplicated markdown

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    94334a0 View commit details
    Browse the repository at this point in the history

  5. Improve naming and conditionals for h3ToCenterChild

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    7a435e1 View commit details
    Browse the repository at this point in the history

  6. Rename getPentagonsAtRes to getPentagonIndexes (similar to getRes0Ind… 

    …exes)
    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    ac223a5 View commit details
    Browse the repository at this point in the history

  7. Add (failing) uncompact tests for resolutions beyond max

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    4f26f52 View commit details
    Browse the repository at this point in the history

  8. Add static helper for child res validity, use for uncompact and child… 

    … functions
    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    61a3a02 View commit details
    Browse the repository at this point in the history

  9. Fix naming and docs nits

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c0f9e18 View commit details
    Browse the repository at this point in the history

  10. Also check pentagons are unique in test

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    32858a0 View commit details
    Browse the repository at this point in the history

  11. Move NUM_PENTAGONS to constants.h

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2650324 View commit details
    Browse the repository at this point in the history

  12. Also use _isValidChildRes in maxH3ToChildrenSize

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2b68770 View commit details
    Browse the repository at this point in the history

  13. Document out param for getPentagonIndexes

    @zachasme
    zachasme committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e036d66 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Remove debug output

    @zachasme
    zachasme committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    5d9b4b6 View commit details
    Browse the repository at this point in the history

  2. Resolve nits

    @zachasme
    zachasme committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    a04cf07 View commit details
    Browse the repository at this point in the history

  3. Docs nits

    @zachasme
    zachasme committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    022c402 View commit details
    Browse the repository at this point in the history

  4. Remove unused variable

    @zachasme
    zachasme committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    713dc72 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Note that child being the same as parent is considered valid in _isVa… 

    …lidChildRes
    @zachasme
    zachasme committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    4a4ad44 View commit details
    Browse the repository at this point in the history