Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make kml #285

Merged
merged 1 commit into from
Nov 4, 2019
Merged

fix make kml #285

merged 1 commit into from
Nov 4, 2019

Conversation

eminden
Copy link
Contributor

@eminden eminden commented Oct 30, 2019

make kml was failing due to flag changes on h3ToHier and h3ToGeoBoundary, updated to newer flag compositions.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.253% when pulling c9316d0 on eminden:make-kml-fix into 739bd26 on uber:master.

Copy link
Collaborator

@dfellis dfellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the branch and it works. Thank you very much! You'll have to sign the CLA for this to be merged, and we'll have to wait for @nrabinowitz or @isaacbrodsky to also review, as they have commit access.

Copy link
Collaborator

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ready to merge as soon as the CLA is signed. Thanks!

@nrabinowitz nrabinowitz merged commit 74280af into uber:master Nov 4, 2019
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants