Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix H3_DIGIT_MASK_NEGATIVE #329

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Apr 2, 2020

Fixes #328 (thanks @lovettchris!) We don't use this specific macro which is why this wasn't found before. We could add tests for some of these macros to ensure they remain working.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.257% when pulling 1ab3a8a on isaacbrodsky:negative-mask-macro into 691ad09 on uber:master.

@isaacbrodsky isaacbrodsky merged commit e137968 into uber:master Apr 5, 2020
@isaacbrodsky isaacbrodsky deleted the negative-mask-macro branch April 5, 2020 15:56
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of H3_DIGIT_MASK_NEGATIVE seems wrong
4 participants