Rename h3SetToLinkedGeo to cellsToLinkedMultiPolygon #571
Conversation
isaacbrodsky
force-pushed
the
linked-geo-rename
branch
from
e52f8fd
to
04f3cac
Compare
|
Partially automated refactoring :) |
| | *DNE* | `loopToBoundary` | | | ||
| | *DNE* | `boundaryToLoop` | | | ||
| | `getH3UnidirectionalEdgeBoundary` | `directedEdgeToBoundary` | returns `CellBoundary` | | ||
| | `h3SetToLinkedGeo` | `cellsToLinkedMultiPolygon` | returns `LinkedGeoPolygon` | |
There was a problem hiding this comment.
Should we also rename LinkedGeoPolygon? This struct is part of the external API, right?
There was a problem hiding this comment.
Per line 269 it looks like the rename should be LinkedGeoMultiPolygon? It's part of the external C API in h3api.h, although it is not needed for binary compatability
There was a problem hiding this comment.
That shouldn't be necessary. The linked structures have a next pointer. So instead of a MultiPolygon with Polygon children, you have a Polygon that can optionally define a pointer to a Polygon sibling.
Maybe the rename isn't necessary - I thought we were dropping the Geo in GeoPolygon, so I was suggesting this should follow suit. But if not, this is fine - though I guess we could update LinkedGeoCoord to LinkedLatLng for consistency.
Rename for consistency with the naming RFC. The name "LinkedMultiPolygon" was chosen so that in the future a "ToMultiPolygon" version could be added; multi was needed since this is inherently a multipolygon as differentiated from polygonToCells which deals only with polygons (non-multi)