Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated faceijk.h include #682

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

jogly
Copy link
Contributor

@jogly jogly commented Sep 9, 2022

this is fine when building standalone, but when including this file in go, go cannot find the header file <faceijk.h>. someone generously wrote a sed processor that removes this line when importing the source, but it would be nice to not have to process this in the bindings <3

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.035% when pulling 6bba21a on jogly:gilley/remove-faceijk-brackets into fb7bb47 on uber:master.

@jogly jogly changed the title chore: remove duplicated faceijk.h include Remove duplicated faceijk.h include Sep 9, 2022
@isaacbrodsky isaacbrodsky merged commit f581626 into uber:master Sep 9, 2022
@jogly jogly deleted the gilley/remove-faceijk-brackets branch September 14, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants