Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept size parameter for polygonToCellsExperimental #947

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

accept size parameter for polygonToCellsExperimental #947

wants to merge 3 commits into from

Conversation

isaacbrodsky
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Coverage Status

coverage: 98.784% (+0.001%) from 98.783%
when pulling f6ffca9 on isaacbrodsky:experimental-polyfill-accept-size
into e45b999 on uber:master.

@ajfriend
Copy link
Contributor

Some basic questions since I've forgotten some of our code organization practice:

  • Should we add polygonToCellsExperimental to h3api.h.in instead of polyfill.h?
  • Does H3_EXPORT serve a purpose outside of h3api.h.in, or does it only make sense in that file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz Awaiting requested review from nrabinowitz

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacbrodsky @coveralls @ajfriend