Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When run in RecordMode can we NOT XCFail the test (for example, use XCTExpectFailure)? #159

Open
appleios opened this issue Sep 2, 2021 · 0 comments

Comments

@appleios
Copy link

appleios commented Sep 2, 2021

Background

I created a script for our team that runs snapshot tests in record mode for iPhone/iPad with correctly selected devices and IOS version.
But when FBSnapshotTestCase runs in record mode we hit the assert:

      assert(recordMode == false, message: "Test ran in record mode. Reference image is now saved. Disable record mode to perform an actual snapshot comparison!", file: file, line: line)

Which leads the whole Xcodebuild exiting with error code 65 with lots of red error lines.

When run using Xcode it is not a problem and is actually convenient (you can see which test were recorder). But when run for recording in one go - the output is too noisy.

Feature Request

Can we add a property shouldFailInRecordMode to the FBSnapshotTestCase so in SwiftSupport.swift the assert will change to:

      assert(!(recordMode && shouldFailInRecordMode), message: "Test ran in record mode. Reference image is now saved. Disable record mode to perform an actual snapshot comparison!", file: file, line: line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant