Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introspection: Add inactive connections to output #686

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

prashantv
Copy link
Contributor

Tried to debug a stuck connection that was stuck in "startClose", but
unfortunately the introspection output was missing the connection as it
expects connections to be added as part of root peers, but peers only
store references to active connections.

Output inactive connections at the top level of the channel (which is
the only thing that has references to inactive connections).

Tried to debug a stuck connection that was stuck in "startClose", but
unfortunately the introspection output was missing the connection as it
expects connections to be added as part of root peers, but peers only
store references to active connections.

Output inactive connections at the top level of the channel (which is
the only thing that has references to inactive connections).
@prashantv prashantv requested a review from witriew March 22, 2018 06:10
@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #686 into dev will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #686      +/-   ##
==========================================
+ Coverage   86.68%   86.92%   +0.24%     
==========================================
  Files          39       39              
  Lines        3959     3963       +4     
==========================================
+ Hits         3432     3445      +13     
+ Misses        403      399       -4     
+ Partials      124      119       -5
Impacted Files Coverage Δ
introspection.go 91.3% <100%> (+0.17%) ⬆️
mex.go 72.09% <0%> (-7.91%) ⬇️
outbound.go 78.73% <0%> (-2.88%) ⬇️
relay.go 84.53% <0%> (+0.65%) ⬆️
channel.go 88.03% <0%> (+1.42%) ⬆️
preinit_connection.go 94.16% <0%> (+1.45%) ⬆️
root_peer_list.go 96% <0%> (+4%) ⬆️
connection.go 84.63% <0%> (+5.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75acd77...354eb1c. Read the comment docs.

@prashantv prashantv merged commit bd37867 into dev Mar 23, 2018
@prashantv prashantv deleted the inactive_introspect branch March 23, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants