Eliminate []byte(string) allocation under thrift transport #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
approved these changes
Mar 29, 2019
thrift/transport.go
Outdated
| b := append(t.strBuf[:0], s...) | ||
| t.strBuf = b[:0] | ||
| return t.Writer.Write(b) | ||
|
|
jcorbin
force-pushed
the
thrift_write_string_alloc
branch
from
223d473
to
02060b8
Compare
Codecov Report
@@ Coverage Diff @@
## dev #729 +/- ##
==========================================
- Coverage 87.77% 87.55% -0.23%
==========================================
Files 40 40
Lines 4075 4075
==========================================
- Hits 3577 3568 -9
- Misses 377 388 +11
+ Partials 121 119 -2
Continue to review full report at Codecov.
|
jcorbin
force-pushed
the
thrift_write_string_alloc
branch
from
02060b8
to
cd8e8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.