CI: fix check_storage_layout for new contracts

[rndquu]

There's the core-contracts-storage-check workflow which checks that contracts' storage is not messed on contract upgrades.

Check these CI runs which fails with the No workflow run found with an artifact named... error:

• https://github.com/ubiquity/ubiquity-dollar/actions/runs/11125075713/job/30912062971?pr=959
• https://github.com/ubiquity/ubiquity-dollar/actions/runs/11145695030/job/30975996318?pr=971

The issue is that when a new contract is added the core-contracts-storage-check starts to fail while the expected behavior for the CI workflow to pass because we don't need to check storage layout for newly added contracts (because storage of the newly added contract hasn't been updated hence storage collision could not occur).

So as a part of this issue we should make sure that:

1. core-contracts-storage-check is not failing for newly added contracts
2. diamond-storage-check.yml is not failing for newly added libraries

P.S. Pls provide a QA in the related PR with these scenarios:

1. No storage updates, CI passing
2. Storage update, no collision, CI passing
3. Storage update, collision, CI failing
4. New contract added, CI passing

[zugdev]

/start

[ubiquity-os]

Deadline	Thu, Oct 3, 4:55 PM UTC
Beneficiary	0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Tip

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

[zugdev]

Can use tj-actions/changed-files for this.

[rndquu]

Can use tj-actions/changed-files for this.

ubiquity-dollar/.github/workflows/core-contracts-storage-check.yml

Line 25 in 20799be

uses: tj-actions/changed-files@v42

[rndquu]

I suppose the simplest solution would be to add a new job step here and here to filter modifed contracts that exist both in the PR and default branches.

[zugdev]

Yes already got it. I meant using tj-actions to see if contract existed last commit in whatever branch.

[zugdev]

I should be reassigned here, waiting for review.

[ubiquity-os]

@zugdev the deadline is at Wed, Oct 16, 8:20 AM UTC

[ubiquity-os]

Passed the deadline and no activity is detected, removing assignees: @zugdev.