Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str should not include NULL byte. #21

Merged
merged 2 commits into from
May 22, 2022
Merged

str should not include NULL byte. #21

merged 2 commits into from
May 22, 2022

Conversation

reitermarkus
Copy link
Collaborator

Also, why is convert_to_str_unchecked called this when in fact it is very much checked?

lkolbly
lkolbly approved these changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@lkolbly lkolbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry for the delay.

Also, why is convert_to_str_unchecked called this when in fact it is very much checked?

Because it might panic, so the _unchecked is intended to emphasize that is_cstr_valid should be called first.

@lkolbly lkolbly merged commit 8db9684 into ublox-rs:master May 22, 2022
@reitermarkus reitermarkus deleted the str-null branch June 14, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkolbly lkolbly lkolbly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @lkolbly