-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configure-grub just command #1206
Conversation
i'll let others comment here too, but I think we're trying to reduce the amount of inline bash scripting in our just files and instead put an actual script on disk and call it from just. |
done, is /usr/libexec the correct location for the script? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comments. menu_auto_hide=2 always hides. Additionally your condition check will say the grub menu is hidden even when it's not.
I think you should have 3 states.
Always Hide, Auto Hide, and Not Hidden. Auto Hide should be the default behaviour on new installs.
Thank you for adding this, and it will be a great place to put the rest of grub logic like removing duplicate entries and regenerating grub.cfg
thank you for adding check for grub state |
based on bazzite configure grub just command with command from hidden grub changeset