Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify UBports recovery via adb #22

Closed
Flohack74 opened this issue Jan 20, 2022 · 4 comments
Closed

Identify UBports recovery via adb #22

Flohack74 opened this issue Jan 20, 2022 · 4 comments

Comments

@Flohack74
Copy link
Member

For proper installation having the UBports recovery onboard is mandatory. Currently the installer happily uses TWRP et.al. and tries to install UT with them, which fails.

Make recovery somehow identifyable from the outside via adb so that we can stop the installer from doing bad things.
@Flohack74 Flohack74 mentioned this issue Jan 20, 2022
Closed
@amartinz
Copy link
Member

We can achieve this with setting a property inside the recovery init.rc.

Which name should the property have?

amartinz added a commit to amartinz/halium_bootable_recovery that referenced this issue Mar 11, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
b500383 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz amartinz mentioned this issue Mar 11, 2022
Merged
@amartinz
Copy link
Member

amartinz commented Mar 11, 2022 •
edited
Loading

Opened a PR with property ro.ubuntu.recovery.
Feel free to adjust to your liking :)

Later on we need to pick it to other branches as well.

Also needs to be actually checked in installer, which is another TODO.

Example usage: adb shell getprop ro.ubuntu.recovery

it returns:

  • true, if the recovery is UBports based
  • nothing or any other value, if the recovery does not support installing Ubuntu Touch via system-image-upgrader

amartinz added a commit to amartinz/halium_bootable_recovery that referenced this issue Mar 12, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
83109bb 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz
Copy link
Member

updated property to ro.ubuntu.recovery based on feedback from @Flohack74

@amartinz amartinz mentioned this issue Mar 16, 2022
Closed
amartinz added a commit to amartinz/halium_bootable_recovery that referenced this issue Mar 17, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
a651db1 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz amartinz mentioned this issue Mar 17, 2022
Merged
amartinz added a commit to amartinz/android_bootable_recovery that referenced this issue Mar 17, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
7d4247c 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports/halium_bootable_recovery#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz amartinz mentioned this issue Mar 17, 2022
Merged
amartinz added a commit to amartinz/android_bootable_recovery that referenced this issue Mar 17, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
b9fe6f5 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports/halium_bootable_recovery#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz amartinz mentioned this issue Mar 17, 2022
Merged
amartinz added a commit to amartinz/android_bootable_recovery that referenced this issue Mar 17, 2022
@amartinz
(ubports) init: set property to identify ubports recovery
e58526c 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports/halium_bootable_recovery#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
@amartinz amartinz mentioned this issue Mar 17, 2022
Merged
@amartinz
Copy link
Member

This is possible now on the installer side with ubports/ubports-installer#2529 and needs installer config changes done by the maintainers.

As all the patches have landed for the recoveries, they need to be rebuilt and it should start working.

neochapay pushed a commit to neochapay/halium_bootable_recovery that referenced this issue Apr 11, 2022
@amartinz @neochapay
(ubports) init: set property to identify ubports recovery
4dcbb00 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
neochapay pushed a commit to neochapay/halium_bootable_recovery that referenced this issue May 16, 2022
@amartinz @neochapay
(ubports) init: set property to identify ubports recovery
2d2bea1 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
NotKit pushed a commit that referenced this issue May 16, 2022
@amartinz @neochapay
(ubports) init: set property to identify ubports recovery
daa9d4e 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: #22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
NotKit pushed a commit that referenced this issue Jun 12, 2022
@amartinz @neochapay
(ubports) init: set property to identify ubports recovery
98f0d07 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: #22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Flohack74 pushed a commit that referenced this issue Apr 9, 2023
@fredldotme @Flohack74
Merge pull request #22 from ubports/add-legacy-channel-flag-7.1
2aecd2a 
Check for legacy channel flag and hardlink system.img again

(cherry picked from commit 85ea41287b3c51fa781749c652adec182cf13e0b)
JamiKettunen pushed a commit to JamiKettunen/halium_bootable_recovery that referenced this issue May 5, 2023
@amartinz @JamiKettunen
(ubports) init: set property to identify ubports recovery
dd6b12d 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
JamiKettunen pushed a commit to JamiKettunen/halium_bootable_recovery that referenced this issue Aug 24, 2024
@amartinz @JamiKettunen
(ubports) init: set property to identify ubports recovery
4495ae7 
The UBports installer has no way of knowing, if the recovery currently
used is a UBports specific recovery, which is required in order to
install Ubuntu Touch via system-image-upgrader.

Set a property which we can check for with ADB to detect if a recovery
supporting system-image-upgrader is running.

Issue: ubports#22

Change-Id: I0f2a00a0a8f9b68203804f1c61f9b639cf7227fc
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartinz @Flohack74