-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to quit with cmd+q to electron menu for our macOS users #1047
Comments
Keeping the application open after the x is closed is conventional on macos, that's why we do it like that. It might be okay to break the convention though, as we are not a normal app that you will want to return to after closing. Not sure what I think about this. |
I agree with that, clicking the x doesn't need to quit the application. However, I still think that hitting command-q should quit and that there should be a quit option in the menubar. Those, I think, are the convention on macos. |
Included in 0.5.6-beta. |
The only way to quit the ubports installer is to right click on the dock icon and select quit. The typical way is to hit command-q (which does nothing) or to select quit from the menu bar (there is no quit option there). I think it would make the experience better if those methods of closing the application were available.
The close button (red X) on the window will only close the window, the application will remain open.
Automatically generated error report
UBports Installer Version: 0.4.11-beta
Device: mako
OS to install: Ubuntu Touch
Settings: {"channel":"ubports-touch/16.04/stable","wipe":false,"bootstrap":true}
Package: dmg
Operating System: macOS 10.14.618G1012 x64
NodeJS version: v8.2.1
Error log: https://paste.ubuntu.com//p/HMM2zwg6nk/
The text was updated successfully, but these errors were encountered: