Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to quit with cmd+q to electron menu for our macOS users #1047

Closed
vlladdrakk opened this issue Dec 2, 2019 · 3 comments · Fixed by #1463
Closed

Add option to quit with cmd+q to electron menu for our macOS users #1047

vlladdrakk opened this issue Dec 2, 2019 · 3 comments · Fixed by #1463
Assignees
Labels
enhancement a new feature or an improvement of existing functionality

Comments

@vlladdrakk
Copy link

The only way to quit the ubports installer is to right click on the dock icon and select quit. The typical way is to hit command-q (which does nothing) or to select quit from the menu bar (there is no quit option there). I think it would make the experience better if those methods of closing the application were available.
The close button (red X) on the window will only close the window, the application will remain open.

Automatically generated error report
UBports Installer Version: 0.4.11-beta
Device: mako
OS to install: Ubuntu Touch
Settings: {"channel":"ubports-touch/16.04/stable","wipe":false,"bootstrap":true}
Package: dmg
Operating System: macOS 10.14.618G1012 x64
NodeJS version: v8.2.1

Error log: https://paste.ubuntu.com//p/HMM2zwg6nk/

@NeoTheThird NeoTheThird added enhancement a new feature or an improvement of existing functionality good first issue reserved for new contributors to get acquainted with the code labels Dec 3, 2019
@NeoTheThird NeoTheThird changed the title Difficult quit the installer on macOS Add option to quit with cmd+q to electron menu Dec 3, 2019
@NeoTheThird NeoTheThird changed the title Add option to quit with cmd+q to electron menu Add option to quit with cmd+q to electron menu for our macOS users Dec 3, 2019
@NeoTheThird
Copy link
Member

Keeping the application open after the x is closed is conventional on macos, that's why we do it like that. It might be okay to break the convention though, as we are not a normal app that you will want to return to after closing. Not sure what I think about this.

@vlladdrakk
Copy link
Author

I agree with that, clicking the x doesn't need to quit the application. However, I still think that hitting command-q should quit and that there should be a quit option in the menubar. Those, I think, are the convention on macos.

@NeoTheThird NeoTheThird removed the good first issue reserved for new contributors to get acquainted with the code label Oct 24, 2020
@NeoTheThird NeoTheThird self-assigned this Oct 24, 2020
NeoTheThird added a commit that referenced this issue Oct 24, 2020
NeoTheThird added a commit that referenced this issue Oct 25, 2020
@NeoTheThird
Copy link
Member

Included in 0.5.6-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or an improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants