Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distro-state test #95

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix distro-state test #95

merged 1 commit into from
Jan 8, 2024

Conversation

EduardGomezEscandell
Copy link
Collaborator

No description provided.

@EduardGomezEscandell EduardGomezEscandell self-assigned this Jan 8, 2024
@EduardGomezEscandell EduardGomezEscandell changed the base branch from main to update-golangci-lint January 8, 2024 10:09
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review January 8, 2024 10:16
@EduardGomezEscandell EduardGomezEscandell requested a review from a team as a code owner January 8, 2024 10:16
@EduardGomezEscandell EduardGomezEscandell marked this pull request as draft January 8, 2024 10:16
@EduardGomezEscandell EduardGomezEscandell mentioned this pull request Jan 8, 2024
Merged
CarlosNihelton
CarlosNihelton approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽
It's marked as draft though.

Base automatically changed from update-golangci-lint to main January 8, 2024 12:58
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review January 8, 2024 12:58
@EduardGomezEscandell
Copy link
Collaborator Author

It's marked as draft though.

Yeah, wanted to rebase first

@EduardGomezEscandell EduardGomezEscandell merged commit 76726a8 into main Jan 8, 2024
3 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the fix-registration-test branch January 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNihelton CarlosNihelton CarlosNihelton approved these changes

Assignees

@EduardGomezEscandell EduardGomezEscandell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardGomezEscandell @CarlosNihelton