Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taiwanese Chinese(zh_TW) localization not working #1857

Closed
brlin-tw opened this issue Oct 30, 2024 · 6 comments · Fixed by #1864
Closed

Taiwanese Chinese(zh_TW) localization not working #1857

brlin-tw opened this issue Oct 30, 2024 · 6 comments · Fixed by #1864

Comments

@brlin-tw
Copy link
Contributor

brlin-tw commented Oct 30, 2024

I have the zh_TW locale set in the system settings:

$ locale
LANG=zh_TW.UTF-8
LANGUAGE=zh_TW:zh_CN:en
LC_CTYPE="zh_TW.UTF-8"
LC_NUMERIC=zh_TW.UTF-8
LC_TIME=zh_TW.UTF-8
LC_COLLATE="zh_TW.UTF-8"
LC_MONETARY=zh_TW.UTF-8
LC_MESSAGES="zh_TW.UTF-8"
LC_PAPER=zh_TW.UTF-8
LC_NAME=zh_TW.UTF-8
LC_ADDRESS=zh_TW.UTF-8
LC_TELEPHONE=zh_TW.UTF-8
LC_MEASUREMENT=zh_TW.UTF-8
LC_IDENTIFICATION=zh_TW.UTF-8
LC_ALL=

but the UI still shows zh_CN translated strings:

Screenshot

Version: revision b277210 (which should have zh_TW translation available since revision eea5279)

@d-loose
Copy link
Member

d-loose commented Oct 31, 2024

Thanks for your report!
Currently there are no translations in app_zh_TW.arb, so I think app_zh.arb is used as a fallback.
There might be something wrong with the weblate setup - the available components there are zh_Hans and zh_Hant. I'll have a closer look at this next week!

@brlin-tw
Copy link
Contributor Author

@d-loose

Thanks for your attention! IMHO the zh_Hans and zh_Hant shouldn't be used and should be replaced with region-specific zh_XX locale codes.

@taijuin
Copy link
Contributor

taijuin commented Nov 5, 2024

Maybe just the same way as other projects.
123

@d-loose
Copy link
Member

d-loose commented Nov 19, 2024

@d-loose

Thanks for your attention! IMHO the zh_Hans and zh_Hant shouldn't be used and should be replaced with region-specific zh_XX locale codes.

Thanks, I've commented on our current setup in #1864. I think this is in line with the setup used on launchpad (see here and here.
In principle Flutter supports a more advanced locale setup, but I don't think this is supported by weblate (and we currently don't have the time to look into that, unfortunately).

A new build should land in the latest/edge and 2/edge channels of the snap-store snap in a few hours. Please feel free to re-open this issue in case there are still some problems :)

@taijuin
Copy link
Contributor

taijuin commented Nov 20, 2024

001

ok~!

Thanks

@brlin-tw
Copy link
Contributor Author

@d-loose

A new build should land in the latest/edge and 2/edge channels of the snap-store snap in a few hours. Please feel free to re-open this issue in case there are still some problems :)

Apologies for the ignorance, I can verify the build in the 2/edge channel works, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants