Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Components: Golden tests #848

Open
jpnurmi opened this issue Mar 11, 2023 · 5 comments
Open

Material Components: Golden tests #848

jpnurmi opened this issue Mar 11, 2023 · 5 comments
Labels
testing Everything related to tests theme

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Mar 11, 2023

Perhaps we could have a simple golden test that takes screenshots of all pages in the example with the different variants? It's somewhat tedious and error-prone to manually browse the example back and forth with several themes. :)

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 11, 2023

Intentional theme changes would need to be coupled with flutter test --update-goldens and it would slowly increase the repo size but at least we'd have a better overview of how PRs affect various theme variants and modes... what do you say?

jpnurmi referenced this issue in jpnurmi/yaru.dart Mar 14, 2023
jpnurmi referenced this issue in jpnurmi/yaru.dart Mar 14, 2023
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
jpnurmi referenced this issue in jpnurmi/yaru.dart May 18, 2023
Ref: #315
@Feichtmeier Feichtmeier transferred this issue from ubuntu/archive_yaru.dart Feb 25, 2024
@Feichtmeier Feichtmeier changed the title Golden tests Material Component: Golden tests Mar 3, 2024
@Feichtmeier
Copy link
Member

@Jupi007 couldnts we eventually copy those tests from flutter/flutter for the pure material widgets?

@Feichtmeier Feichtmeier added testing Everything related to tests theme labels Mar 3, 2024
@Feichtmeier Feichtmeier changed the title Material Component: Golden tests Material Components: Golden tests Mar 3, 2024
@Jupi007
Copy link
Member

Jupi007 commented Mar 3, 2024

@Feichtmeier This will be very heavy to maintain, isn't it?
I think the original JP's idea is better. Btw his code is already working, why didn't he make a PR?

@Feichtmeier
Copy link
Member

@Feichtmeier This will be very heavy to maintain, isn't it?
I think the original JP's idea is better. Btw his code is already working, why didn't he make a PR?

I have no idea. Maybe it wasn't finished

@Feichtmeier
Copy link
Member

Here is JPs work for future work on this
https://github.com/ubuntu/archive_yaru.dart/pull/320/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Everything related to tests theme
Projects
None yet
Development

No branches or pull requests

3 participants