Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TestPolicyExamples/Any case #19

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

fabiobozzo
Copy link
Collaborator

Statement: ["any", ".a", ["==", ".b", 2]]
Data: {"a": [{"b": 1}, {"b": 2}, {"z": [7, 8, 9]}]}

Selector selects a sub-slice at first (many): [{"b": 1}, {"b": 2}].

Furthermore, the case seg.Field() != "" was not equipped to handle subject ipld.Node of kind 'Kind_List'.

@fabiobozzo fabiobozzo marked this pull request as ready for review September 16, 2024 11:03
Copy link
Collaborator

@smoyer64 smoyer64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you have to also change that "supported forms" test that was missing the }?

@fabiobozzo
Copy link
Collaborator Author

@smoyer64 that was in my previous (larger) PR: #18 👈 Please check that out, too.

@fabiobozzo fabiobozzo merged commit 06e0674 into v1 Sep 16, 2024
6 checks passed
@smoyer64
Copy link
Collaborator

Ah - #18 is merged (I knew I saw that change when we discussed the bad IPLD syntax)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants