Rewrite simple glob match + FuzzMatch #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobozzo
changed the title
|
By fuzzing, I've found (large) inputs that takes forever to How should we treat those? Shouldn't the spec enforce a limit both on policy statements and node size? |
MichaelMure
reviewed
Sep 17, 2024
capability/policy/policy.go
Outdated
| return nil, err | ||
| } | ||
| return wildcard{selector: selector, pattern: pattern, glob: g}, nil | ||
| return wildcard{selector: selector, pattern: pattern}, nil |
There was a problem hiding this comment.
imho, you should validate the pattern here
There was a problem hiding this comment.
Possibly, you could have a Parse function or something like that, that return a type (type Pattern string for example). Then you can attach the "match" function on that type.
Really nitpicking though.
There was a problem hiding this comment.
@MichaelMure is that what you mean? 16ba4b3
|
Good results from fuzzing, after converting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
github.com/gobwas/globwith spec-based implementation, and perform fuzz tests onMatch.