Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .jsx files to .js #141

Closed
nathanmsmith opened this issue Sep 4, 2017 · 1 comment
Closed

Rename .jsx files to .js #141

nathanmsmith opened this issue Sep 4, 2017 · 1 comment
Assignees

Comments

@nathanmsmith
Copy link
Member

Context

Recently, I came across an issue where the contributors of create-react-app advocated for dropping .jsx extension for the .js extension. I started to do this in a new branch, but then came across a linter error and found that airbnb prefers use of the .jsx syntax. I wanted to open it up for discussion of which file extension we want to use. Personally, I'm in the .js camp as that seems to be more popular and gaining traction.

@binerys
Copy link
Member

binerys commented Sep 26, 2017

If it doesn't really affect our build system (looks like webpack will easily handle the .js version), I'm with the use of .js. Simplicity and consistency is better in the end.

@binerys binerys assigned nathanmsmith and unassigned binerys Sep 26, 2017
@nathanmsmith nathanmsmith mentioned this issue Oct 6, 2017
10 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants