Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 544: Insert disjoint classes Endurant and Perdurant into hierarchy #559

Draft
wants to merge 10 commits into
base: develop-2.0.0
Choose a base branch
from
Draft

Issue 544: Insert disjoint classes Endurant and Perdurant into hierarchy #559

wants to merge 10 commits into from

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Nov 7, 2023 •
edited
Loading

This Pull Request resolves all requirements of Issue #544 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (1aac32a)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable-2.0.0 as submodule (ead959d )
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Nov 7, 2023
@ajnelson-nist
Insert disjoint classes Endurant and Perdurant into hierarchy
f93c5cc 
This patch also adds the relating properties `core:hasParticipant` and
`core:isPerdurantProperPartOf`, as suggested in Issue 544.

No effects were observed on Make-managed files.

References:
* #544

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist linked an issue Nov 7, 2023 that may be closed by this pull request
Support the distinction between Perdurants and Endurants #544
Open
13 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 7, 2023
Open
13 tasks
@ajnelson-nist
Copy link
Contributor Author

@plbt5 , how should we spell the inverses of the new properties?

@ajnelson-nist
Copy link
Contributor Author

This PR has been updated to incorporate core:Event from #541 as a core:Perdurant subclass.

@ajnelson-nist
Designate Event a subclass of Perdurant
1f50a29 
No effects were observed on Make-managed files.

References:
* #541
* #544

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Fix typo
16a6b3d 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

Testing for adding core:Event to this PR has completed, with no troubles found in CI.

@ajnelson-nist
Merge branch 'develop-2.0.0' into Feature-Issue-544
6b5cb85
@ajnelson-nist
Shift Endurant to be subclass of UcoThing
8fa859f 
This covers the potential for Qualities (under proposal in Issue 535),
which in multiple foundational ontologies are acknowledged as endurants,
but in UCO would be inherent characterization things.

No effects were observed on Make-managed files.

References:
* #535
* #544

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

Testing has been refreshed after shifting Endurant up above UcoObject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

Support the distinction between Perdurants and Endurants
2 participants
@ajnelson-nist @plbt5