Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into MVC form #1

Open
gonfunko opened this issue May 22, 2013 · 3 comments
Open

Refactor into MVC form #1

gonfunko opened this issue May 22, 2013 · 3 comments

Comments

@gonfunko
Copy link
Contributor

Instead of one class, break the project up into several classes MVC style. Look at Lab 6 for an example.

~estimated 200

@EricHuang2
Copy link
Contributor

~claimed @EricHuang2 ~moderator @CARammelkamp

@pconrad
Copy link
Contributor

pconrad commented Jun 7, 2013

This does NOT properly factor the game into MVC form. True, there are three files named Gomoku.java, Controller.java and Viewer.java. But MVC is more than just having three files with those names. It is about SEPARATING GAME LOGIC from GRAPHICS/VIEW logic. And this code does NOT do that.

Further, one of the benefits of doing MVC is to be able to have a model that is independent of any view logic, so that it can be unit tested. Note that there is no unit testing. Also, try to play the game. The game has a BUG that the original did not have----note that Gunnar's original, if you get 5 in a row, let's you know visually and with a message on standard output, that you won the game. This version does NOT.

So, a future issue is to actually do MVC separate properly, and another is to fix the bug. I would suggest, if the bug can be fixed quickly this quarter, do that only. Otherwise, if a W14 student is taking this on, try to do both.. proper MVC AND fix the bug.

@pconrad pconrad reopened this Jun 7, 2013
@asyung
Copy link
Contributor

asyung commented Oct 6, 2016

F16 OK (250 points)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants