Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon toolbar is not applying marks when it's a child of Plate (multiple editors) #1345

Closed
zbeyens opened this issue Jan 14, 2022 · 3 comments · Fixed by #1377
Closed

Balloon toolbar is not applying marks when it's a child of Plate (multiple editors) #1345

zbeyens opened this issue Jan 14, 2022 · 3 comments · Fixed by #1377
Labels
bug Something isn't working toolbar

Comments

@zbeyens
Copy link
Member

zbeyens commented Jan 14, 2022

The balloon toolbar works in both editors in the example, do you have the same issue?

Yes, in your example (docs), it works as expected. But I'm facing the same issue as before.

To illustrate it, I have created a live demo and a repository with the source. Inline, only the last editor is working. If you switch to Default, it's working as expected with multiple editors. I hope this example code may help.

Originally posted by @dtslvr in #1309 (comment)

@zbeyens zbeyens added toolbar bug Something isn't working labels Jan 14, 2022
@zbeyens zbeyens changed the title Balloon toolbar is not applying marks when child of Plate (multiple editors) Balloon toolbar is not applying marks when it's a child of Plate (multiple editors) Jan 14, 2022
@dtslvr
Copy link
Contributor

dtslvr commented Jan 21, 2022

Thank you for creating a dedicated bug report @zbeyens.
Do have an idea where the problem is? Or could you maybe give some instructions that I can try to fix it myself?

@zbeyens
Copy link
Member Author

zbeyens commented Jan 21, 2022

It looks like we get the wrong editor there

const focusId = useEventEditorSelectors.focus();
const editor = usePlateEditorState(focusId!)!;

@zbeyens zbeyens mentioned this issue Feb 8, 2022
@dtslvr
Copy link
Contributor

dtslvr commented Feb 25, 2022

Thank you very much for the fix @zbeyens 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working toolbar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants