Table cell selection: support all transforms

[Croc-ye]

Description

Reproduction URL

No response

Reproduction steps

1. Go to 'https://platejs.org/'
2. Click on 'Table'
3. Select multiple cells vertically to across rows.
4. set right alignment
5. error happened

Plate version

42.0.0

Slate React version

0.112.0

Screenshots

No response

Logs

No response

Browsers

Chrome

[Croc-ye]

such as Numbered List, Bulleted List, Todo are the same

[Croc-ye]

I have a preliminary plan. Please help me see if it is feasible.

export const withAlignTable: ExtendEditor<TableConfig> = ({ editor }) => {
  const { apply } = editor;

  editor.apply = (op) => {
    if (
      op.type === 'set_node'
      // @ts-ignore
      && op?.newProperties?.align !== op.properties.align
    ) {
      // 说明 align 有变化
      const { selection } = editor;

      if (Range.isRange(selection) && hasMultiTr(editor)) {
        console.log('set_node align', op);

        const tdEntry = getAboveNode(editor, {
          at: op.path,
          match: n => isBlock(editor, n) && n.type === ELEMENT_TD,
        });
        if (tdEntry) {
          // console.log('nn @@@', nn);
          const cells = getTableGridAbove(editor, {
            at: selection!,
            format: 'cell',
          }) as TNodeEntry<TTableCellElement>[];
          const tdIdsInSelection: string[] = [];
          cells.forEach((td) => {
            td?.[0]?.id && tdIdsInSelection.push(td[0].id as string);
            // console.log('td', td);
          });
          if (!tdIdsInSelection.includes(tdEntry[0].id)) {
            console.log('not include ', tdEntry);
            return;
          }
        }
      }
    }

    apply(op);
  };

  return editor;
};

[zbeyens]

We have many transforms, I think we should override all transform methods like setNodes to be generic.

[Croc-ye]

We have many transforms, I think we should override all transform methods like setNodes to be generic.

You are right.

[zbeyens]

This would consist of many setNodes for each selected cell path, since selecting a column does not form a single range.