Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple playlists #29

Open
aniketgattani opened this issue Dec 12, 2017 · 4 comments
Open

Add multiple playlists #29

aniketgattani opened this issue Dec 12, 2017 · 4 comments

Comments

@aniketgattani
Copy link

aniketgattani commented Dec 12, 2017

I would like to work on this issue and provide a PR for the same.

  1. I would like to make all variables respective to a playlist.
  2. Add multiple playlists to localStorage and keep another variable in it "no_of_playlists"
  3. I would also make a change in the UI and display name of the playlist according to its id.
  4. I would add a "Add a playlist" option and a function for the same.
@udiboy1209
Copy link
Owner

So currently in localStorage, a variable playlist is stored which is a list of snippets. You need to change it to a list of lists.

I don't think explicitly storing the no_of_playlists is necessary, but do whatever makes your implementation easy and we'll see later.

You could extend the playlist module, or maybe create a new module for playlist switching.

For the UI, I had thought a dropdown list of playlists in the top right corner, with a "plus" icon to create new playlist would be good.

Do think of a better implementation if possible. Let's discuss this feature here further before you start implementation.

@aniketgattani
Copy link
Author

Actually I didnt think of the no of playlists just wrote it anyway :p. For the UI I thought of the samething. Probably later I will make another PR in which the playlist name will be editable. For now I will be mainly focusing on the backend portion and will submit the PR in bits for u to check easily. Anything u want in UI is mostly welcomed coz I am not that gr8 in it :p. So should I start then with the backend part ??

@udiboy1209
Copy link
Owner

You can start in anyway you are comfortable. Keep the whole feature in a single PR, so it is easy for me to review. Although you can keep updating it as you progress and test your code, and I will be able to review every part. The point is I will not be able to merge the back-end without the front-end, because that will break the beta. So if they both are in a single PR, it will be easily mergable.

Don't hesitate to ask questions, and join the Gitter chat in case you want to ask something. 😄

@aniketgattani
Copy link
Author

@udiboy1209 can u please help me in the gitter chat. I have asked some doubts there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants