Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormArray Within A FormGroup #139

Closed
ellipizle opened this issue Oct 5, 2016 · 6 comments
Closed

FormArray Within A FormGroup #139

ellipizle opened this issue Oct 5, 2016 · 6 comments

Comments

@ellipizle
Copy link

First of all i must commend you for this great library you have done.
I really appreciate your work and effort.

I am trying to create a formArray with a formGroup. from the samples i can guess the library is expecting the form array at the top level not within a formgroup.
i get an error ORIGINAL EXCEPTION: Cannot find control with path: 'hh_member_names_repeat -> 0,

I will be grateful if you can give me a hint on how i can hack this library to create a fromArray with a FormGroup.

@ellipizle
Copy link
Author

I found out my mistake after some digging, i was having multiple control with the same name.
the form array displays perfectly now. but, the template [add and remove button] are not displaying.

@udos86
Copy link
Owner

udos86 commented Oct 6, 2016

@ellipizle Thanks for your nice message and your contribution. I'll have look at it. This could be a bug. I will let you know as soon as possible.

@udos86 udos86 added the bug label Oct 6, 2016
@udos86
Copy link
Owner

udos86 commented Oct 6, 2016

@ellipizle I confirm, this is a bug. Please give me a couple of days to evaluate an appropriate solution. Thanks.

@udos86
Copy link
Owner

udos86 commented Oct 9, 2016

@ellipizle Good news! I actually have found a solution to this. Have a look at 20bda4b. Fix will land in 1.0.5.

@udos86 udos86 closed this as completed in 20bda4b Oct 12, 2016
@ellipizle
Copy link
Author

sorry for not responding sooner, i have been off the radar for sometime now.
Wow! Nice. Thank you.
I will really like to contribute to this library, but i am still trying to wrap my head around angular 2 form module and given the fact that i am new to typescript/ javascript programming I bet I have alot to learn.
Thank you once again

@udos86
Copy link
Owner

udos86 commented Oct 28, 2016

@ellipizle No problem, thanks for your nice message!

@udos86 udos86 added the core label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants