Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ng-bootstrap #278

Closed
sadiqhabib opened this issue Feb 15, 2017 · 5 comments
Closed

Add ng-bootstrap #278

sadiqhabib opened this issue Feb 15, 2017 · 5 comments

Comments

@sadiqhabib
Copy link

Hi I am interested to add ng-bootstrap.
I also tried as well to add it. I am really interested to contribute in this amazing project.

@udos86
Copy link
Owner

udos86 commented Feb 15, 2017

@sadiqhabib Thanks for your message!

If you'd like to contribute ng-bootstrap support you generally would have to add ng-bootstrap as an optional dependency and implement a new component and a new template to the DynamicFormsBootstrapUIModule. Please also see CONTRIBUTION GUIDE.

@sadiqhabib
Copy link
Author

I Created new branch according to CONTRIBUTION GUIDE now I am trying to import ng-bootstrap inside ui-ngbootstrap module. But now I am getting problem to lint this module.

ui-ngbootstrap/src/ui-ngbootstrap.module.ts[4, 27]: ' should be "
'lint:modules' errored after 2.07 s
Error in plugin 'gulp-tslint'
Message:
    Failed to lint: ui-ngbootstrap/src/ui-ngbootstrap.module.ts [4, 27]: ' should be ".

Can you please tell me where is the problem.
Thank you

@udos86
Copy link
Owner

udos86 commented Feb 16, 2017

@sadiqhabib Please don't add a new module. You better extend the current ui-bootstrap package by adding

  • DynamicFormNGBootstrapComponent
  • dynamic-form-ng-bootstrap.component.html
  • DynamicFormsNGBootstrapUIModule
  • ng-bootstrap as optional dependency to package.json

Your lint error is self-explaining: you're using single quotes instead of double quotes.

Thanks for your effort!

@sadiqhabib
Copy link
Author

@udos86 Thank you for guiding me. Now I added files as you defined above. But now I an getting problem to start example. it is related to template parsing but until now i did not edit any template. Can you please tell me what I am doing wrong.
Thank you

@udos86
Copy link
Owner

udos86 commented Feb 21, 2017

@sadiqhabib Sorry, from afar it's impossible to tell what's wrong. Remember that after building the modules via npm run build:modules you also need to import your new NgModule into the AppModule in order to run it in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants