Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra new line on "return" click in iOS #1214

Closed
nucleartux opened this issue Apr 24, 2021 · 2 comments
Closed

Extra new line on "return" click in iOS #1214

nucleartux opened this issue Apr 24, 2021 · 2 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@nucleartux
Copy link
Contributor

nucleartux commented Apr 24, 2021 •
edited
Loading

Description
A clear and concise description of what the bug is.

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Go to https://www.tiptap.dev/guide/node-views/react/#adding-a-content-editable
  2. Press "Return"
  3. See extra new line inside box

In Vue example extra new whole interactive box appears.

Environment?

  • operating system: iOS
  • browser: Safari
RPReplay_Final1619271586.mp4
RPReplay_Final1619271825.mp4
@nucleartux nucleartux added Type: Bug The issue or pullrequest is related to a bug v2 labels Apr 24, 2021
@nucleartux nucleartux changed the title Extra new line on enter on iOS Extra new line on "return" click in iOS Apr 24, 2021
@philippkuehn
Copy link
Contributor

This seems to be an issue with ProseMirror. I created an issue: ProseMirror/prosemirror#1162

@philippkuehn
Copy link
Contributor

Okay this seems to be fixed in the latest release. But there is still an issue with iOS as described here (ProseMirror/prosemirror#1162 (comment)): node views will be re-created when pressing enter. There has been an idea for a while to build a node view cache that could probably catch this case but for now I’m closing this.

@thatsjonsense thatsjonsense mentioned this issue Nov 17, 2021
Merged
@albertogiunta albertogiunta mentioned this issue Oct 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nucleartux @philippkuehn