fix(core): only respect text of node before current position (#2937)

[svenadlung]

Hopefully this PR fixes #2937

Since node.textContent always looks at the entire text of the node, the desired behavior worked out well at the end but not once the position is somewhere else within the text.

I replaced it with nodeBefore

Get the node directly before the position, if any. If the position points into a text node, only the part of that node before the position is returned.

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	e155b31
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/62bdf47ca2468b0008dd870a
😎 Deploy Preview	https://deploy-preview-2941--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[gnapse]

Hey @svenadlung, I work closely with @rfgamaral, and he's going to be unavailable for a while, so I can take over his involvement in this issue. Would you be so kind to let me know what would be the best way to try these changes locally? I have very little experience with tiptap's development, unlike @rfgamaral.

[svenadlung]

Hi @gnapse, I think you could try https://deploy-preview-2941--tiptap-embed.netlify.app/preview/ and see if the behaviour works like expected.

If you want to try it on your local machine you could clone the fix/input-rule-fix branch.

[gnapse]

Hi @gnapse, I think you could try deploy-preview-2941--tiptap-embed.netlify.app/preview and see if the behaviour works like expected.

If you want to try it on your local machine you could clone the fix/input-rule-fix branch.

Thanks for the pointer. Indeed, it seems to work as expected in that instance:

CleanShot.2022-07-05.at.14.18.30.mp4

As opposed to when I try the same in https://tiptap.dev/examples/default

So what are the next steps to have this become part of a new release? Can I help in any way?

[bdbch]

Good find! Thanks for fixing this issue.