fix(core): implement deleteCurrentNode command & fix node joining on Delete key

[bdbch]

This PR should fix #2924 by adding a new command called deleteCurrentNode.

This command is then used inside the keymap core extension right before the joinForward command to check if the current node is empty - if it is, the current node will be simply deleted instead of joining the empty node with the next node.

This way, if for example an empty paragraph node is followed by an blockquote, the empty paragraph node will be removed and the selection will be moved into the blockquote.

If the paragraph node is not empty, the blockquote will be transformed into a paragraph node as it used to be.

[netlify]

❌ Deploy Preview for tiptap-embed failed.

Name	Link
🔨 Latest commit	4efbfef
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/6380e0409fab2300088d08f5

[rfgamaral]

@bdbch This is awesome, thanks for taking the time to dig into this one.

However, while attempting to fix this on my side (I couldn't), I found an edge case that I'm not sure if this implementation takes care of. The deployment seems to have failed, but I'll try to find some time today to check out this branch, and test it out. I'll let you know what I find as soon as possible.

[bdbch]

Thanks for your response @rfgamaral! I'm taking a look into the failed deployment right now.

[bdbch]

Seems like the Netlify cache was breaking the build. It's deployed now. Feel free to test here:
https://6320b6c00a7e9271f33a732c--tiptap-embed.netlify.app/src/examples/book/react/

[bdbch]

What edge case did you find?

[rfgamaral]

@bdbch This one:

firefox_mTdG8AWAPO.mp4

Based on my experience with other editors, in this particular case, the blockquote node (or other block node like a list item) should indeed be removed, and the text joined with the paragraph where the cursor was.

Short demo from Google Docs:

firefox_59sdQyvkQN.mp4

Hope you can fix this one as well 🤞

[bdbch]

I'll take a look at this case too!

[bdbch]

@rfgamaral sorry didn't find time yesterday, was quite late already haha. I'll take a look at my PR later this day and I'll see if I can find a quick solution for the issue you showed me.

[rfgamaral]

@bdbch That's okay, I understand, take the time required to get it right 👍

[bdbch]

@rfgamaral I worked on this a bit but couldn't figure out the "right" way to do it. What I'm on right now:

1. Get to the parent node (for example the paragraph)
2. Look for the next text node found after the parent node (for example in the next paragraph, list item, etc)
3. Copy the text to the end of the current cursor $anchor position
4. IF the next node is not a text node, we will skip and merge the next node as usual
5. Remove the parent of the copied text node

But I'm not 100% sure if this is the expected behaviour. I'm still experimenting - just a heads up for what is going on in here.

[bdbch]

@rfgamaral since this PR takes longer I'll merge it soon and release it with the next release. I created a new issue for the edgecase you reported: #3454

[aleclarson]

This command should be marked @internal or at least have its behavior documented more clearly. I tried using it thinking it would delete the current node, but the current node was not empty, so it wasn't deleted, leading me to think Tiptap was broken.