fix(react): fix rebinding events not overwriting editor.on #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
approved these changes
Apr 3, 2023
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
…s#3935) * fix(react): fix rebinding events not overwriting editor.on * fix(react): move ref assignment inside if
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
…s#3935) * fix(react): fix rebinding events not overwriting editor.on * fix(react): move ref assignment inside if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes the issue described in #3932 by unbinding specific event handlers instead of all event handlers in a hook inside
useEditor.How did you accomplish your changes
How have you tested your changes
I created a local demo to test this behavior. It didn't create to many callbacks & correctly unregistered old ones. Also events registered via
Editor.onwere working correctly.How can we verify your changes
Create a local React demo and register a callback via
editor.on.Remarks
Nothing to remark
Checklist
Related issues
editor.on("update", callback)is never getting called whenonUpdate()is defined #3932