Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: redo doesn't work correctly #4403

Closed
1 of 2 tasks
fEyebrow opened this issue Aug 31, 2023 · 0 comments · Fixed by #4435
Closed
1 of 2 tasks

[Bug]: redo doesn't work correctly #4403

fEyebrow opened this issue Aug 31, 2023 · 0 comments · Fixed by #4435
Assignees
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@fEyebrow
Copy link

Which packages did you experience the bug in?

prosemirror-keymap

What Tiptap version are you using?

2.1.7

What’s the bug you are facing?

Upon using extension-history, when the "editor?.can().redo()" is false, I press the Shift-Mod-z. However, undo is triggered instead. Subsequently, when I active Shift-Mod-z again, the redo is called. If I continue to press Shift-Mod-z, undo and redo will be alternately triggered.

a gif from example:
iShot_2023-08-31_14 58 24

Here is my dependencies:

  1. "@tiptap/extension-color": "^2.1.7",
  2. "@tiptap/extension-font-family": "^2.1.7",
  3. "@tiptap/extension-link": "^2.1.7",
  4. "@tiptap/extension-placeholder": "^2.1.7",
  5. "@tiptap/extension-text-align": "^2.1.7",
  6. "@tiptap/extension-text-style": "^2.1.7",
  7. "@tiptap/extension-underline": "^2.1.7",
  8. "@tiptap/pm": "^2.1.7",
  9. "@tiptap/starter-kit": "^2.1.7",
  10. "@tiptap/vue-3": "^2.1.7",

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

when the "editor?.can().redo()" is false, I press the Shift-Mod-z, but no action is triggered.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@fEyebrow fEyebrow added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants