Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Queue Providers from qpush-bundle #101

Closed
jeremygiberson opened this issue Jun 13, 2016 · 2 comments
Closed

Decouple Queue Providers from qpush-bundle #101

jeremygiberson opened this issue Jun 13, 2016 · 2 comments

Comments

@jeremygiberson
Copy link

In general, I would greatly welcome an abstraction layer for multiple queues and this bundle does just that [in addition to some other stuff]. I'd really like to see the queue Provider interface and the provider adapters for ironmq, aws, file, etc to be pulled out into a separate library(s).

@k-k
Copy link
Contributor

k-k commented Jun 30, 2016

Im definitely not opposed to this - but not sure if I have the bandwidth to look at doing it right now. Not sure if there is more interest from the community?

@jeremygiberson
Copy link
Author

I'm happy to help with this. I'm willing to pull the code out into its own library and make a PR that requires the new package. I'll need you to fork it and submit it to packagist though so it stays under your vendor name. Once its available, I'll submit a pull request against qpush-bundle that drops the classes and requires the libraries.

@k-k k-k closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants