Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about wait for existence of a file? #20

Closed
sharifzadesina opened this issue Jan 7, 2020 · 5 comments
Closed

What about wait for existence of a file? #20

sharifzadesina opened this issue Jan 7, 2020 · 5 comments

Comments

@sharifzadesina
Copy link

Sometimes, like when we are initializing database, the port is accessible but our database is not yet initialized, so we need to wait for database file creation.
This will be a simple feature but a useful one.

@ufoscout
Copy link
Owner

@sharifzadesina
I am sorry for the late reply, I would like to keep this utility as small as possible in terms of both features and configuration options. Anyway, if you propose a PR that does not introduce external dependencies, I would indeed take it into account.

@edumco
Copy link
Contributor

edumco commented May 8, 2021

@sharifzadesina This sound like a similar utility that could be implemented completely independently from docker-compose-wait like a second command (maybe wait-file) that could be released as another package (crate ?).

This would keep the wait simple, small, ultra-fast and reliable and at the same time could extend options for another use cases.

@ufoscout this can be done inside this code base or should be made in another repository?

@ufoscout
Copy link
Owner

ufoscout commented May 8, 2021

@edumco
As said before, a PR would be welcome for this one.

@sharifzadesina
Copy link
Author

@ufoscout I already did it both on one package.
https://github.com/elegantweb/docker-wait

They are bot "waiting" so it is better to be on the same package.

@ufoscout
Copy link
Owner

This is now fixed.
With version 2.9.0 you can now wait for files and/or directories using the new environment variable WAIT_PATHS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants