Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The noahmptable.tbl file is mandatory, even for configurations that don't need it. #107

Closed
SamuelTrahanNOAA opened this issue Sep 22, 2023 · 0 comments · Fixed by #106, ufs-community/ufs-weather-model#1893 or #102
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

The GFS_phys_time_vary.fv3.F90 reads the noahmptable.tbl file unconditionally. Even configurations that don't need that table will try to read it. The code tries to set errflg=1 if the file is missing. (Though, as of this writing, that file's error checking is broken: #105)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Run a non-noahmp suite many times.
  2. Some of the runs will fail. It should be 100% of the runs, but the error checking is broken (GFS_phys_time_vary_init does not report errmsg/errflg correctly due to thread race condition #105) so errors in that routine are usually not reported.

Additional Context

Discovered by @hu5970 in the RRFS parallels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment