Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ozinterp and h2ointerp data is read when it is not needed #108

Closed
SamuelTrahanNOAA opened this issue Sep 22, 2023 · 0 comments · Fixed by #106, ufs-community/ufs-weather-model#1893 or #102
Closed

ozinterp and h2ointerp data is read when it is not needed #108

SamuelTrahanNOAA opened this issue Sep 22, 2023 · 0 comments · Fixed by #106, ufs-community/ufs-weather-model#1893 or #102
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

The ozinterp and h2ointerp data is read unconditionally in GFS_time_vary_pre.fv3.F90. This makes the files mandatory, even for configurations that don't need them. That error may not be caught due to bug #105 but it will be caught after that bug is fixed.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Choose a suite that doesn't need one of those files, and ensure the file is missing.
  2. Run it many times. It'll succeed frequently due to bug GFS_phys_time_vary_init does not report errmsg/errflg correctly due to thread race condition #105 but it'll eventually fail.
@SamuelTrahanNOAA SamuelTrahanNOAA added the bug Something isn't working label Sep 22, 2023
This was referenced Sep 22, 2023
Merged
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@SamuelTrahanNOAA