Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow end-to-end script should follow standard syntax for arguments, documentation needs updating #369

Closed
mkavulich opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mkavulich
Copy link
Collaborator

Original issue opened by @climbfuji migrated from regional_workflow repository: ufs-community/regional_workflow#607

Description

Currently the workflow end-to-end script uses a non-standard format for arguments passed to the script, for example:

./run_WE2E_tests.sh \
    tests_file="explist.txt" \
    machine="HERA" \
    account="gsd-hpcs"

Standard syntax would be

./run_WE2E_tests.sh \
    --tests_file="explist.txt" \
    --machine="HERA" \
    --account="gsd-hpcs"

or

./run_WE2E_tests.sh \
    -t "explist.txt" \
    -m "HERA" \
    -a "gsd-hpcs"

or a mixture of these. This should be changed, because it causes unnecessary confusion.

Also, the documentation in https://ufs-srweather-app.readthedocs.io/en/latest/WE2Etests.html is outdated.

Solution

Adopt standard syntax and update documentation.

Alternative Solutions

Do nothing and make life for users harder than necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant