Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting scripts should be part of the workflow #481

Closed
danielabdi-noaa opened this issue Nov 16, 2022 · 0 comments · Fixed by #482
Closed

Plotting scripts should be part of the workflow #481

danielabdi-noaa opened this issue Nov 16, 2022 · 0 comments · Fixed by #482
Assignees
Labels
enhancement New feature or request

Comments

@danielabdi-noaa
Copy link
Collaborator

danielabdi-noaa commented Nov 16, 2022

Description

Currently plotting scripts under ush/Python are standalone scripts run optionally by the user. I believe they should be part
of the workflow.

Solution

  • Create a new rocoto task plot_allvars to handle this as part of the workflow. This will avoid the need for the job submission scripts sq_job.sh and pbs_job.sh etc
  • plot_allvars_diff.py plots the difference between two experiments so the experiment would need to know which other experiment it needs to compare to.
  • Remove the ush/Python folder once the above solution is implemented

Requirements**

pygraf environement is needed. Cartopy shapefiles are needed but seem to be available on Tier-1 platforms according to the docs: https://srw-ug.readthedocs.io/en/release-public-v2.1.0/Graphics.html

Update:: pygraf environment seem to be part of regional_workflow environment now with the new EPIC modulefiles so no new packages are necessary.

Acceptance Criteria (Definition of Done)

  • Produce graphics as part of the workflow
  • Both raw and diff graphics
  • Can be optinally turned off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant