-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce test cases from ufs-case-studies platform #753
Comments
The point of these tests is to make sure that we know where these files are and that they work for this type of file. It's not about a specific test case or data. If it runs fast enough on other platforms, we can skip it on Hera. Alternatively, retrieve_data.py could be modified to just confirm that a file exists and skip pulling it. In that case, we assume that wget would work for a file that exists, but we still check that. |
Thanks for the comments, @christinaholtNOAA , and I totally agreed (as I pointed out we could skip these tests on some platforms in the original PR). If no one else has other opinions, #776 would be a good hotfix for this issue. We then can move forward to add test cases thru WE2E framework. Thanks. |
Closed with PR #776. |
Description
Per discussion (#736), The "retrieve_data.py" unit tests now take a very long time to run (more than an hour for a single file on Hera!) due to having to retrieve very large nemsio files over the internet for the ufs-case-studies cases.
EPIC-DTO team has a deliverable to include 4 scientifically-validated UFS test cases (must be from ufs-case-studies platform based on the description) into SRW apps.
Solution
The solution will be thru #776 as @christinaholtNOAA recommended. EPIC-DTO plans to add the following cases to SRW apps:
Short summary for IBCS/LBCS/configurations can be found in this confluence page.
FYI @EdwardSnyder-NOAA. I noticed RRFS also have plans to add test cases for RRFS release. Please feel free to let me know if there is an overlap. We can coordinate accordingly.
The text was updated successfully, but these errors were encountered: