Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for esmf and mapl debug versions #1680

Closed
climbfuji opened this issue Mar 24, 2023 · 3 comments · Fixed by #1681
Closed

Remove requirement for esmf and mapl debug versions #1680

climbfuji opened this issue Mar 24, 2023 · 3 comments · Fixed by #1681
Assignees
Labels
Baseline Updates Current baselines will be updated. enhancement New feature or request

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Mar 24, 2023

Description

The ufs-weather-model currently requires the software stack providers to create modules for esmf and mapl in debug mode that get used when the debug flag is enabled. This creates unnecessary burden on the software stack developers. For example, the first version of spack-stack (1.3.0) for the UFS will contain 4! versions of ESMF and 4! versions of MAPL:

esmf/8.3.0b09-debug
esmf/8.3.0b09            
esmf/8.4.1-debug   
esmf/8.4.1
mapl/2.22.0-debug-esmf-8.3.0b09-debug
mapl/2.22.0-esmf-8.3.0b09            
mapl/2.35.2-debug-esmf-8.4.1-debug   
mapl/2.35.2-esmf-8.4.1      

I don't think this is required. If the ESMF and MAPL developers want to debug problems with their software with ESMF or MAPL, they can (and often will) compile their own versions of ESMF and MAPL, with debug flags enabled, and use those.

Why "and often will"? Because when you are debugging a segmentation fault or something like that, you may start out with the official library, but then make changes based on a develop or bug fix version of ESMF and/or MAPL which you have to compile yourself anyway. What's more, the ESMF and MAPL developers are versed in using spack and have no problem building whatever version they need on whatever platform they need.

Solution

Remove the requirement for ESMF and MAPL debug versions from the ufs-weather-model. And, while we are at, remove the DEBUG_LINKMPI logic as well (see #330 for more information).

The sooner this is done, the earlier the full transition to spack-stack can happen.

Alternatives

The current status quo makes our life more complicated than it needs to be.

Related to

#330

@climbfuji climbfuji added enhancement New feature or request Baseline Updates Current baselines will be updated. labels Mar 24, 2023
@climbfuji
Copy link
Collaborator Author

@climbfuji
Copy link
Collaborator Author

I am volunteering to make this change if there is a chance for it to be accepted.

@DusanJovic-NOAA
Copy link
Collaborator

I support this change.

#1651 (comment)

#330 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. enhancement New feature or request
Projects
No open projects
2 participants