Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for traditional threading #2533

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • [] Commit 'test_changes.list' from previous step

Description:

This PR adds support for traditional (non esmf managed) threading. Currently, all '2threads' tests have been converted to traditional threading. ESMF managed threading is still the default.

To use tradition threading, set ESMF_THREADING=false in test's configuration file and set THRD to number of threads, for example:

$ cat tests/cpld_2threads_p8
. . . 
ESMF_THREADING=false
THRD=$THRD_cpl_thrd

Many tests had two versions of ufs.configure templates (_esmf.IN and the version without _esmf) with the only difference being the value of globalResourceControl:, true for esmf and false for non-esmf threading. Those are now unified in a single ufs.configure template.

Commit Message:

* UFSWM - This PR adds support for traditional (non esmf managed) threading. ESMF managed threading is still default.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Use this variable to turn on writing histaux files every MED_history_n.
By default it is .false.
Currently only cpld_control_nowave_noaero_p8 test has it turned on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set traditional threading as default
2 participants